style: simplify string formatting for readability #1072
Conversation
|
@hamirmahal is attempting to deploy a commit to the Gloo Team on Vercel. A member of the Team first needs to authorize it. |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 709ae7d in 39 seconds
More details
- Looked at
2847lines of code in77files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. engine/baml-runtime/src/internal/llm_client/orchestrator/call.rs:44
- Draft comment:
The string formatting here has been updated to use the new Rust syntax, which improves readability and is consistent with the PR's intent. - Reason this comment was not posted:
Confidence changes required:10%
The PR aims to simplify string formatting using the new Rust syntax. This change is consistent with the PR's intent and improves readability.
2. engine/baml-runtime/src/internal/llm_client/orchestrator/stream.rs:51
- Draft comment:
The string formatting here has been updated to use the new Rust syntax, which improves readability and is consistent with the PR's intent. - Reason this comment was not posted:
Confidence changes required:10%
The PR aims to simplify string formatting using the new Rust syntax. This change is consistent with the PR's intent and improves readability.
3. engine/language_client_codegen/src/dir_writer.rs:71
- Draft comment:
The string formatting here has been updated to use the new Rust syntax, which improves readability and is consistent with the PR's intent. - Reason this comment was not posted:
Confidence changes required:10%
The PR aims to simplify string formatting using the new Rust syntax. This change is consistent with the PR's intent and improves readability.
Workflow ID: wflow_ye3HdeSn0fwbBqHa
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
Hi there- thanks for making this PR! We always love to see new contributors :) Can I ask if there's something you're working on right now that this makes easier? Or is there automation (e.g. I primarily ask because this touches a lot of code and while I'd love to merge this, we do have some really big WIPs that will conflict with this change and if possible, I'd like to defer this until those land. |
|
Hello! You're welcome. That's fine. Feel free to ping me once the large WIPs are through: I can take another look at this then. I wouldn't want to create a bunch of merge conflicts for any large in-progress pull requests. |
|
Amazing - I'll set a reminder to check back in on this in a week, and make sure that the rest of us know so that we can keep a window open for this to go in when they're in. |
closes #1071.